fix(js client): increase scope of retries#384
Merged
GuillaumeDecMeetsMore merged 3 commits intomasterfrom Aug 27, 2025
Merged
Conversation
mm-zacharydavison
requested changes
Aug 27, 2025
clients/javascript/lib/baseClient.ts
Outdated
| } | ||
|
|
||
| // List of endpoints that can be retried without side-effects | ||
| const ENDPOINTS_THAT_CAN_BE_RETRIED: string[] = [ |
There was a problem hiding this comment.
I wonder would it be better to define this as a decorator on the endpoints, or similar? So that the configuration of if it can be retried is next to the endpoint itself.
Collaborator
Author
There was a problem hiding this comment.
Good idea, I've adapted 👍
Ideally I wanted to avoid duplicating the URL, but I think it would mean proxying the POST requests themselves to populate the set, or to have a factory for creating the methods that are idempotents. Both cases seemed too complex to me compared to just using constants
mm-zacharydavison
approved these changes
Aug 27, 2025
GuillaumeDecMeetsMore
deleted the
guillaume/fix/js-client-increase-scope-of-retries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed