Add Version Catalog and Gradle plugin convention#36
Merged
Conversation
mhdabbaghy
approved these changes
Jul 8, 2023
Collaborator
mhdabbaghy
left a comment
There was a problem hiding this comment.
I'm okay with migrating to the version catalog
But I think we need more discussion about writing convention plugins, my idea was to create an inner project called "build-logic" and write all of our plugins inside of it
Owner
Author
Hey @mhdabbaghy, I agree too; this PR is just a declaration of conventions because we don't have any modules. In the future, we should add this module and also migrate from Groovy to kotlin kts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Impact
Add Version Catalog and Gradle plugin convention.
Type of change