Skip to content

Add Version Catalog and Gradle plugin convention#36

Merged
mehdiyari merged 3 commits intodevfrom
add_version_catalog
Jul 8, 2023
Merged

Add Version Catalog and Gradle plugin convention#36
mehdiyari merged 3 commits intodevfrom
add_version_catalog

Conversation

@mehdiyari
Copy link
Copy Markdown
Owner

Description and Impact

Add Version Catalog and Gradle plugin convention.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

@mehdiyari mehdiyari requested a review from mhdabbaghy July 8, 2023 14:47
@mehdiyari mehdiyari linked an issue Jul 8, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@mhdabbaghy mhdabbaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with migrating to the version catalog
But I think we need more discussion about writing convention plugins, my idea was to create an inner project called "build-logic" and write all of our plugins inside of it

@mehdiyari
Copy link
Copy Markdown
Owner Author

I'm okay with migrating to the version catalog But I think we need more discussion about writing convention plugins, my idea was to create an inner project called "build-logic" and write all of our plugins inside of it

Hey @mhdabbaghy, I agree too; this PR is just a declaration of conventions because we don't have any modules. In the future, we should add this module and also migrate from Groovy to kotlin kts.

@mehdiyari mehdiyari merged commit 366bfa5 into dev Jul 8, 2023
@mehdiyari mehdiyari deleted the add_version_catalog branch July 11, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate on version catalog and gradle plugin convention

2 participants