rename modules #99
Merged
rename modules #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
reviewed
Nov 30, 2025
pgrayy
reviewed
Nov 30, 2025
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
reviewed
Nov 30, 2025
| from .models.bidi_model import BidiModel | ||
|
|
||
| # Model providers - What users need to create models | ||
| from .models.gemini_live import BidiGeminiLiveModel |
Collaborator
There was a problem hiding this comment.
Since right now we have explicit bidi-gemini and bidi-openi dependency groups in our pyproject.toml, we won't want to import the models top-level (nova is fine). As an alternative, we can include all the model dependencies as part of the bidi list for now.
| from .openai import BidiOpenAIRealtimeModel | ||
| from .model import BidiModel, BidiModelTimeoutError | ||
| from .nova_sonic import BidiNovaSonicModel | ||
| from .openai_realtime import BidiOpenAIRealtimeModel |
Collaborator
There was a problem hiding this comment.
Same thing here. Since OpenAI and Gemini are optional, we won't want to import them in init.
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
reviewed
Nov 30, 2025
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
reviewed
Nov 30, 2025
| Handles different types of content: | ||
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename modules
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.