Skip to content

Conversation

@meian
Copy link
Owner

@meian meian commented Mar 21, 2022

Closes #96

What changed

Describe a clear and concise what you changed in pull request.

Others

Add any other context about pull request here.


Checklist

  • Issue is linked.
    • It is not needed if simple edit such as corrections of words, etc.
  • Test is added.
    • If fixed bug, add case on existing test or add new test.
    • If add new feature, add new test.
    • Add benchmark test, as needed.
  • Test coverage rate has no decreased.
    • If rate is decreased, explain why in What changed.

@meian meian added improvement Some improvement environment For environment labels Mar 21, 2022
@meian meian self-assigned this Mar 21, 2022
@meian meian force-pushed the 96-apply-linter-on-ci branch from f2182af to 5549d51 Compare March 21, 2022 15:49
@meian meian force-pushed the 96-apply-linter-on-ci branch 2 times, most recently from 9ab5fd4 to 36503f2 Compare September 8, 2022 17:05
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #111 (2338717) into main (66f79d7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2338717 differs from pull request most recent head 9c2eb36. Consider uploading reports for the commit 9c2eb36 to get more accurate results

@@            Coverage Diff            @@
##              main      #111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          725       725           
=========================================
  Hits           725       725           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
concat.go 100.00% <ø> (ø)
distinct.go 100.00% <ø> (ø)
filter.go 100.00% <ø> (ø)
map.go 100.00% <ø> (ø)
skip.go 100.00% <ø> (ø)
slice.go 100.00% <ø> (ø)
take.go 100.00% <ø> (ø)
repeat.go 100.00% <100.00%> (ø)
reverse.go 100.00% <100.00%> (ø)
skip_last.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@meian meian force-pushed the 96-apply-linter-on-ci branch 3 times, most recently from 552b16b to be9ffaa Compare September 8, 2022 18:09
@meian meian force-pushed the 96-apply-linter-on-ci branch from 2338717 to e2d41ea Compare September 8, 2022 19:53
@meian meian marked this pull request as ready for review September 8, 2022 19:54
@meian meian force-pushed the 96-apply-linter-on-ci branch from e2d41ea to 9c2eb36 Compare September 8, 2022 19:56
@meian meian merged commit 248a3de into main Sep 8, 2022
@meian meian deleted the 96-apply-linter-on-ci branch September 8, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

environment For environment improvement Some improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal]Apply linter on CI

1 participant