[MEIER-236] Add DNS records for meiermade.com and andrewmeier.dev redirects#77
[MEIER-236] Add DNS records for meiermade.com and andrewmeier.dev redirects#77benjimeierdev merged 3 commits intomainfrom
Conversation
…irects Add proxied A records pointing to 192.0.2.1 (dummy IP) so Cloudflare can intercept requests and apply the existing redirect rulesets: - andrewmeier.dev root -> andymeier.dev - meiermade.com root -> andymeier.dev/services - www.meiermade.com -> andymeier.dev/services
🍹
|
andymeierdev
left a comment
There was a problem hiding this comment.
Looks good overall — standard Cloudflare pattern for redirect-only domains. A few minor observations:
1. Duplicate zone lookups — andrewmeierZone and meiermadeZone are now looked up in both record.ts and redirect.ts. Could extract to a shared zones.ts, but not a functional issue since Pulumi deduplicates API calls. Fine to leave for now.
2. package-lock.json churn — 4 removed "peer": true lines look like an npm install side-effect rather than intentional. Harmless but worth a quick sanity check that it doesn't affect the build.
3. No www.andrewmeier.dev record — The redirect ruleset only matches http.host eq "andrewmeier.dev" so this is consistent, but if someone hits www.andrewmeier.dev it'll just fail to resolve. Probably fine since it's not a marketed domain, but worth a quick decision.
4. Pre-merge — Did you run pulumi preview? AGENTS.md requires it before PR to confirm the 3 new DNS records create cleanly.
benjimeierdev
left a comment
There was a problem hiding this comment.
Thanks for the review! Addressing each point:
1. Duplicate zone lookups — Agreed, fine to leave for now. Can extract to a shared zones.ts in a follow-up if the file grows.
2. package-lock.json churn — Good catch, reverted in c2c1705. Was just an npm install side-effect from my local node version.
3. No www.andrewmeier.dev — Since the redirect ruleset only matches http.host eq "andrewmeier.dev", adding a DNS record without a matching rule wouldn't help. Leaving as-is since it's not a marketed domain. Happy to add both (DNS record + rule) if you'd like.
4. Pulumi preview — CI ran it successfully: 3 DNS records to create, no errors. I ran tsc --noEmit locally for type checking but didn't have Pulumi credentials for a local preview.
andymeierdev
left a comment
There was a problem hiding this comment.
Could we also add www.andrewmeier.dev record
Per review feedback, added: - www.andrewmeier.dev proxied A record (192.0.2.1) - Updated andrewmeier.dev redirect rule to also match www.andrewmeier.dev
Problem
meiermade.comandandrewmeier.devdon't resolve — the redirect rulesets exist inredirect.tsbut there are no DNS records for Cloudflare to proxy, so the redirects never fire.Fix
Added proxied A records pointing to
192.0.2.1(dummy IP) inrecord.tsso Cloudflare can intercept requests and apply the existing redirect rulesets:andrewmeier.dev(root) → redirects toandymeier.dev(via existing ruleset)meiermade.com(root) → redirects toandymeier.dev/services(via existing ruleset)www.meiermade.com→ redirects toandymeier.dev/services(via existing ruleset)Files Changed
pulumi/src/cloudflare/record.ts— added DNS records for andrewmeier.dev, meiermade.com, and www.meiermade.comCloses previous approach in platform-infrastructure#44.