Skip to content

Conversation

@ishika22
Copy link
Contributor

@netlify
Copy link

netlify bot commented Oct 19, 2021

✔️ Deploy Preview for distracted-wiles-3edfc5 ready!

🔨 Explore the source changes: 9480495

🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-wiles-3edfc5/deploys/616f0c58631dd90007ed3b40

😎 Browse the preview: https://deploy-preview-1214--distracted-wiles-3edfc5.netlify.app

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ishika22 for your contribution!!

I will open issue to update this in the SDKs :)

@curquiza curquiza linked an issue Oct 20, 2021 that may be closed by this pull request
2 tasks
@curquiza
Copy link
Member

@guimachiavelli I linked the issue to this PR to ensure bors closes it once it's merged :)
feel free to remove it if I'm wrong

@guimachiavelli
Copy link
Member

Ok! Two approvals, we're good to go! Thanks for the contribution, @ishika22!

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 20, 2021

Build succeeded:

@curquiza
Copy link
Member

@ishika22
If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

bors bot added a commit to meilisearch/meilisearch-ruby that referenced this pull request Oct 22, 2021
252: Update distinct_attribute_1 values in .code-samples.meilisearch.yaml r=curquiza a=AudTheCodeWitch

This PR changes .code-samples.meilisearch.yaml in accordance with meilisearch/documentation#1214

- [x] `get_distinct_attribute_1` - change "movies" to "shoes"
- [x] `update_distinct_attribute_1` - change "movies" to "shoes"
- [x] `update_distinct_attribute_1` - change "movie_id" to "skuid"
- [x] `reset_distinct_attribute_1` - change "movies" to "shoes"

Closes #248 

Co-authored-by: Audrea Cook <aud@codewitch.dev>
bors bot added a commit to meilisearch/meilisearch-dart that referenced this pull request Oct 23, 2021
108: Update meilisearch code samples for distinct_attribute values r=curquiza a=reginaalyssa

This PR addresses issue #106 by updating the `.code-samples.meilisearch.yaml` file in line with meilisearch/documentation#1214

* `distinct_attribute` values were changed from `'movies'` to `'shoes'` and from `'movie_id'` to `'skuid'`

Co-authored-by: Regina Alyssa <reginaalyssa01809@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examples of distinct attribute (API References)

3 participants