-
Notifications
You must be signed in to change notification settings - Fork 270
Update distinct attribute #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for distracted-wiles-3edfc5 ready! 🔨 Explore the source changes: 9480495 🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-wiles-3edfc5/deploys/616f0c58631dd90007ed3b40 😎 Browse the preview: https://deploy-preview-1214--distracted-wiles-3edfc5.netlify.app |
guimachiavelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ishika22 for your contribution!!
I will open issue to update this in the SDKs :)
|
@guimachiavelli I linked the issue to this PR to ensure bors closes it once it's merged :) |
|
Ok! Two approvals, we're good to go! Thanks for the contribution, @ishika22! bors merge |
|
Build succeeded: |
|
@ishika22 |
252: Update distinct_attribute_1 values in .code-samples.meilisearch.yaml r=curquiza a=AudTheCodeWitch This PR changes .code-samples.meilisearch.yaml in accordance with meilisearch/documentation#1214 - [x] `get_distinct_attribute_1` - change "movies" to "shoes" - [x] `update_distinct_attribute_1` - change "movies" to "shoes" - [x] `update_distinct_attribute_1` - change "movie_id" to "skuid" - [x] `reset_distinct_attribute_1` - change "movies" to "shoes" Closes #248 Co-authored-by: Audrea Cook <aud@codewitch.dev>
108: Update meilisearch code samples for distinct_attribute values r=curquiza a=reginaalyssa This PR addresses issue #106 by updating the `.code-samples.meilisearch.yaml` file in line with meilisearch/documentation#1214 * `distinct_attribute` values were changed from `'movies'` to `'shoes'` and from `'movie_id'` to `'skuid'` Co-authored-by: Regina Alyssa <reginaalyssa01809@gmail.com>
#491