Skip to content

Conversation

@Rijoanul-Shanto
Copy link
Contributor

Pull Request

What does this PR do?

This PR corrects the source key in the Meilisearch Getting Started guide, where the embedder source for OpenAI was incorrectly documented as openai instead of the correct openAi. Since embedder sources are case-sensitive, this fix ensures accuracy and prevents potential misconfigurations.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, wow, this went completely unnoticed by quite a few of our internal reviews. Thanks for fixing it @Rijoanul-Shanto, much appreciated!

@guimachiavelli guimachiavelli merged commit fd2e3d8 into meilisearch:main Feb 17, 2025
1 of 2 checks passed
@Rijoanul-Shanto
Copy link
Contributor Author

oh, wow, this went completely unnoticed by quite a few of our internal reviews. Thanks for fixing it @Rijoanul-Shanto, much appreciated!

been playing with Meilisearch a lot these days 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants