Skip to content

Conversation

@guimachiavelli
Copy link
Member

Fixes EXP-622

@guimachiavelli guimachiavelli marked this pull request as ready for review October 15, 2025 15:22
@guimachiavelli guimachiavelli requested a review from a team as a code owner October 15, 2025 15:22
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me. However, I'm sorry I forgot to explain that the compaction is done in another file (we erase the non-compacted file by the compacted one) and at much twice the size of the disk is required to do the compaction.

Co-authored-by: Clément Renault <clement@meilisearch.com>
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 👍

@guimachiavelli guimachiavelli merged commit 00686cf into main Oct 16, 2025
4 checks passed
@guimachiavelli guimachiavelli deleted the exp-622-compact-route branch October 16, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants