Skip to content

Conversation

@eskombro
Copy link
Contributor

This is the Tutorial for running a MeiliSearch in production. Still needs to be checked by myself for grammar etc, checked by someone else for content validation / test, and finally go through some native English speaker for polishing purposes :)

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great tutorial! I've learned so much reading through it. Thanks a lot. This is high quality stuff 🙌

@bidoubiwa
Copy link
Contributor

Why did you chose to add the whole rust-toolchain installation instead of the binary download with curl?

@eskombro eskombro marked this pull request as ready for review May 4, 2020 14:03
@eskombro eskombro requested a review from bidoubiwa May 4, 2020 14:03
@tpayet
Copy link
Member

tpayet commented May 4, 2020

I remember while reading this tutorial that we have to write somewhere in the documentation that for best performance, it is always good to compile MeiliSearch on the machine you intend to run it because that way you will be sure that the binary will have all the optimization that the compiler could make for this specific architecture.

Great content anyway @eskombro

@eskombro
Copy link
Contributor Author

eskombro commented May 4, 2020

I remember while reading this tutorial that we have to write somewhere in the documentation that for best performance, it is always good to compile MeiliSearch on the machine you intend to run it because that way you will be sure that the binary will have all the optimization that the compiler could make for this specific architecture.

Great content anyway @eskombro

Thanks!

The last version had the installation with the source code and compiling MeiliSearch. But after discussing a bit with @Kerollmops and @bidoubiwa it really seems that it adds some complexity and makes it too long for a 'tutorial' scope. Do you think we should reconsider it or add some side-note, or anything @tpayet ?

@tpayet
Copy link
Member

tpayet commented May 4, 2020

Nope, I agree it may be useless in this scope. I just created the issue about writing the upper comment in the documentation (#346)

@bidoubiwa bidoubiwa requested a review from matboivin May 4, 2020 15:38
@bidoubiwa bidoubiwa requested a review from curquiza May 5, 2020 10:15
@meilisearch meilisearch deleted a comment from eskombro May 5, 2020
@meilisearch meilisearch deleted a comment from eskombro May 5, 2020
eskombro and others added 2 commits May 5, 2020 16:10
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bidoubiwa bidoubiwa merged commit 1115d97 into meilisearch:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants