Skip to content

Conversation

@dichotommy
Copy link
Contributor

Attempt to improve the documentation around searchable attributes as requested in #580 .

"Attribute Importance" renamed to "Attribute Ranking Order". Information removed from API References and Main Concepts and consolidated in /guides/advanced_guides/field_properties.md.

I'm still unclear on the meaning of the last paragraph of #580 . Does this mean that if you manually reorder your searchableAttributes list, then reset it, the reset list will maintain the order you set, adding in all other attributes (new or previously non-searchable) to the end of the list?

If so, then wouldn't "reset" be a misnomer? It would actually be keeping your order while restoring the behavior of automatically adding all attributes.

@bidoubiwa
Copy link
Contributor

I'm still unclear on the meaning of the last paragraph of #580 . Does this mean that if you manually reorder your searchableAttributes list, then reset it, the reset list will maintain the order you set, adding in all other attributes (new or previously non-searchable) to the end of the list?

If so, then wouldn't "reset" be a misnomer? It would actually be keeping your order while restoring the behavior of automatically adding all attributes.

Absolutely. This is something we are thinking on how we might improve it. The first step is to improve the documentation around it to receive feedback from users. After which, we can think (or not) about a rework.

It could also be interesting to initiate conversations with users on slack in order to know if they realize this setting also orders the attributes by importance (@fharper).

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome awesome job! This is made way more clear :)

@dichotommy dichotommy mentioned this pull request Jan 6, 2021
bidoubiwa
bidoubiwa previously approved these changes Jan 13, 2021
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great great rewrite!! 🚀🔥

Tommy Melvin and others added 2 commits January 13, 2021 12:01
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REALLY USEFUL GUIDE! Thanks so much. This is a key guide we absolutely needed 🔥🔥🔥🔥

@dichotommy dichotommy merged commit ac4db3f into meilisearch:master Jan 13, 2021
@dichotommy dichotommy deleted the searchable_attributes branch January 13, 2021 17:04
@dichotommy
Copy link
Contributor Author

Fixes #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants