-
Notifications
You must be signed in to change notification settings - Fork 268
Searchable attributes #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searchable attributes #652
Conversation
Absolutely. This is something we are thinking on how we might improve it. The first step is to improve the documentation around it to receive feedback from users. After which, we can think (or not) about a rework. It could also be interesting to initiate conversations with users on slack in order to know if they realize this setting also orders the attributes by importance (@fharper). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome awesome job! This is made way more clear :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great great rewrite!! 🚀🔥
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
cff3968 to
ef59aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REALLY USEFUL GUIDE! Thanks so much. This is a key guide we absolutely needed 🔥🔥🔥🔥
|
Fixes #580 |
Attempt to improve the documentation around searchable attributes as requested in #580 .
"Attribute Importance" renamed to "Attribute Ranking Order". Information removed from API References and Main Concepts and consolidated in /guides/advanced_guides/field_properties.md.
I'm still unclear on the meaning of the last paragraph of #580 . Does this mean that if you manually reorder your searchableAttributes list, then reset it, the reset list will maintain the order you set, adding in all other attributes (new or previously non-searchable) to the end of the list?
If so, then wouldn't "reset" be a misnomer? It would actually be keeping your order while restoring the behavior of automatically adding all attributes.