Skip to content

Add put_reserved_with_flags to Database#368

Merged
Kerollmops merged 1 commit intomeilisearch:mainfrom
MukundaKatta:feat/put-reserved-with-flags
May 2, 2026
Merged

Add put_reserved_with_flags to Database#368
Kerollmops merged 1 commit intomeilisearch:mainfrom
MukundaKatta:feat/put-reserved-with-flags

Conversation

@MukundaKatta
Copy link
Copy Markdown
Contributor

Closes #366.

Database exposed put_with_flags and put_reserved separately but no combined version, forcing callers who need both reserved-key allocation and write flags to drop down to raw libmdbx. Mirrored the two existing methods into put_reserved_with_flags with the same signature shape and a doc-test.

Couldn't run cargo test locally in this sandbox; CI will verify.

Copy link
Copy Markdown
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, a little note about your comment: we don't rely on mdbx, and users cannot use raw LMDB calls to mirror what the method you implemented does.

Merging 🌵

@Kerollmops Kerollmops added this pull request to the merge queue May 2, 2026
Merged via the queue into meilisearch:main with commit e8d0433 May 2, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing put_reserved_with_flags method

2 participants