Use multi search api for ms v1.1.0 #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a2fa055 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bidoubiwa
force-pushed
the
use_multi_search_api_for_ms_v1.1.0
branch
5 times, most recently
from
68db606 to
5f1e76b
Compare
bidoubiwa
force-pushed
the
use_multi_search_api_for_ms_v1.1.0
branch
4 times, most recently
from
978e4ce to
796f554
Compare
bidoubiwa
commented
Mar 23, 2023
bidoubiwa
commented
Mar 23, 2023
bidoubiwa
force-pushed
the
use_multi_search_api_for_ms_v1.1.0
branch
2 times, most recently
from
73886fe to
0df50b5
Compare
bidoubiwa
commented
Mar 23, 2023
| "@meilisearch/instant-meilisearch": minor | ||
| --- | ||
|
|
||
| Replaces search with multiSearch API. |
brunoocasali
approved these changes
Mar 23, 2023
Member
brunoocasali
left a comment
brunoocasali
left a comment
There was a problem hiding this comment.
LGTM 🎉 multi-search ftw!
bidoubiwa
force-pushed
the
use_multi_search_api_for_ms_v1.1.0
branch
from
ceeeb0b to
8695b69
Compare
…eilisearch v1.1.0
bidoubiwa
force-pushed
the
use_multi_search_api_for_ms_v1.1.0
branch
from
8695b69 to
a2fa055
Compare
Contributor
Author
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Mar 27, 2023
1038: Use multi search api for ms v1.1.0 r=bidoubiwa a=bidoubiwa Replace the usage of `client.index().search` with `client.multiSearch()` when performing searches. - TODO: - [x] Replace search requests made with `client.index.search` with `client.multiSearch` - Pagination - Caching - [x] Use multi-search also when performing the initial facet distribution - [x] Rename `searchResponse` with `searchResult` when it is not the whole response of the multi search API Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Contributor
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the usage of
client.index().searchwithclient.multiSearch()when performing searches.client.index.searchwithclient.multiSearchsearchResponsewithsearchResultwhen it is not the whole response of the multi search API