Use _geoBoundingBox when creating the geo search filter #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 193b350 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bidoubiwa
force-pushed
the
add_geoboundbing_filter
branch
3 times, most recently
from
7ea1edc to
ae33491
Compare
alallema
approved these changes
Mar 29, 2023
Contributor
alallema
left a comment
alallema
left a comment
There was a problem hiding this comment.
LGTM!
Just one question
packages/instant-meilisearch/src/adapter/search-request-adapter/geo-filter-adapter.ts
Outdated
Show resolved
Hide resolved
bidoubiwa
added
breaking-change
bidoubiwa
force-pushed
the
add_geoboundbing_filter
branch
3 times, most recently
from
b927bb6 to
fd1e115
Compare
alallema
approved these changes
Mar 29, 2023
mdubus
reviewed
Mar 30, 2023
packages/instant-meilisearch/src/adapter/search-request-adapter/__tests__/geo-rules.test.ts
Outdated
Show resolved
Hide resolved
packages/instant-meilisearch/src/adapter/search-request-adapter/search-params-adapter.ts
Show resolved
Hide resolved
bidoubiwa
force-pushed
the
add_geoboundbing_filter
branch
from
fd1e115 to
193b350
Compare
bidoubiwa
added a commit
that referenced
this pull request
Mar 30, 2023
* Use _geoBoundingBox to create geosearch filters * Add the _geoBoundingBox changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the specification: meilisearch/specifications#223
We used to transform the
insideBoundingBoxprovided byinstantsearchto a filter using_geoRadius. This required a lot of maths and was not the behavior expected by the user.With the introduction of the
_geoBoundingBoxfilter in Meilisearch, we can now use that instead of_geoRadius.