Skip to content

Conversation

@bidoubiwa
Copy link
Contributor

The version script required by the changeset CI to update the versions of the package was missing.

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 6, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: 4340154

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the purpose of this script. It said to build and update the version for the second, but it seems to write some files.
Sorry, js isn't really my strong suit.

@bidoubiwa bidoubiwa force-pushed the add_missing_version_script branch from 58ddd37 to 4340154 Compare June 6, 2023 14:08
@bidoubiwa bidoubiwa requested a review from alallema June 6, 2023 14:08
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidoubiwa
Copy link
Contributor Author

bors merge

@meili-bors meili-bors bot merged commit 904b6dd into main Jun 6, 2023
@meili-bors meili-bors bot deleted the add_missing_version_script branch June 6, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants