Skip to content

Make autocomplete public on npm #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

Make autocomplete public on npm #1147

merged 1 commit into from
Jun 7, 2023

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jun 7, 2023

the autocomplete-client was added to npm as a private package, making it impossible to access without the writes on the package.

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

⚠️ No Changeset found

Latest commit: 94f9a9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bidoubiwa bidoubiwa requested a review from alallema June 7, 2023 10:59
alallema
alallema approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Jun 7, 2023

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 7, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit b743d25 into main Jun 7, 2023
@meili-bors meili-bors bot deleted the make_autocomplete_public_on_npm branch June 7, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bidoubiwa @alallema