Skip to content

Update yarn lock and cleaning #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 10, 2020
Merged

Update yarn lock and cleaning #135

merged 9 commits into from
Nov 10, 2020

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Nov 9, 2020 •
edited
Loading

In this PR

  • add build in eslintignore to avoid linting the react build folder
  • Add playground build job workflow that checks if the react and vue playground build correctly
  • Add the job to the bors toml
  • Add vue file in the lining command to avoid ignoring them on lint
  • Add two scripts in package json to launch the playground tests
  • Remove eslint from vue playground because it inherits them from root directory
  • Update yarn locks

@bidoubiwa bidoubiwa marked this pull request as draft November 9, 2020 17:39
@bidoubiwa bidoubiwa changed the title Update yarn lock 2 Update yarn lock and cleaning Nov 10, 2020
@bidoubiwa bidoubiwa marked this pull request as ready for review November 10, 2020 10:40
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Nov 10, 2020
curquiza
curquiza requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

bidoubiwa and others added 3 commits November 10, 2020 14:41
@bidoubiwa @curquiza
Apply suggestions from code review
a3d13d3 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bidoubiwa
Rename jobs
00e3fe4
@bidoubiwa
Rename styling check
9456e03
curquiza
curquiza approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, then I approve!
merge when you want

@curquiza
Copy link
Member

curquiza commented Nov 10, 2020

bors try

bors bot added a commit that referenced this pull request Nov 10, 2020
@bors
Try #135:
9658ac6
@bors
Copy link
Contributor

bors bot commented Nov 10, 2020

try

Build succeeded:

curquiza
curquiza previously approved these changes Nov 10, 2020
View reviewed changes
@bidoubiwa @curquiza
Update bors.toml
868be3b 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Nov 10, 2020

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 10, 2020

Build succeeded:

@bors bors bot merged commit 6d58d7b into master Nov 10, 2020
@bors bors bot deleted the update_yarn_lock_2 branch November 10, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bidoubiwa @curquiza