Skip to content

Conversation

@meili-bot
Copy link
Contributor

This PR gathers the changes related to the next MeiliSearch release (v0.22.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:

  • the next release of MeiliSearch (v0.22.0) is out.
  • the meilisearch-js dependency has been released to be compatible with MeiliSearch v0.22.0.
    Once the release is out, the meilisearch-js version in this package should be upgraded and committed to this branch.

This PR is auto-generated for the pre-release week purpose.

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Sep 1, 2021
* Make sortby widget compatible

* Update README with sortBy usage

* Correct words in readme

* Fix sort condition

* Update README.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update README.md

* Update README.md

* End to end sortby tests (#515)

* add sortBy example in playground

* Add tests

* Add persistent demo URL

* Remove temporary meilisearch pkg link

* Add recommendation count in playgrounds

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Table Of Widgets is really nice.
LGTM! 🎉

'https://ms-9060336c1f95-106.saas.meili.dev',
'5d7e1929728417466fd5a82da5a28beb540d3e5bbaf4e01f742e1fb5fd72bb66'
'https://demo-steam.meilisearch.com/',
'90b03f9c47d0f321afae5ae4c4e4f184f53372a2953ab77bca679ff447ecc15c'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should think about hiding this key?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the search key! We want to provide it to the users to have a direct functioning playground. I understand this might be a security issue but we prefer providing development comfort I think. @curquiza

@alallema As this is not related to the PR, could you approve the pr if it is oke for you?

@bidoubiwa bidoubiwa marked this pull request as ready for review September 13, 2021 15:55
alallema
alallema previously approved these changes Sep 13, 2021
@bidoubiwa bidoubiwa marked this pull request as draft September 13, 2021 15:59
@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 13, 2021

Build succeeded:

@bors bors bot merged commit 590b440 into main Sep 13, 2021
@bors bors bot deleted the bump-meilisearch-v0.22.0 branch September 13, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants