-
Notifications
You must be signed in to change notification settings - Fork 66
Update ci versions #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci versions #589
Conversation
|
bors try |
tryBuild succeeded: |
|
Why is there also change about integration tests name in this PR? is this expected? EDIT: I confused, I thought I was asking as reviewer here, but you probably have not finished, sorry! |
Yes it is expected! Should have been in another Pr but I was a bit lazy hhehe |
| status = [ | ||
| 'style-check', | ||
| 'integration-tests (Node.js 12)', | ||
| 'integration-tests (Node.js 14)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 is missing I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont confirm compatibility with node 16 in this PR. This may require additional testing
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Don't forget to change the tests required by GH in the settings ;)
|
bors merge |
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Required status check \"integration-tests\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
You should do it before merging your PR |
|
bors try |
tryBuild succeeded: |
|
bors merge |
settings/branches/main/