Skip to content

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Nov 4, 2021

  • Changes in CI naming should be reflected in settings/branches/main/

@curquiza
Copy link
Member

curquiza commented Nov 4, 2021

bors try

bors bot added a commit that referenced this pull request Nov 4, 2021
@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

@curquiza
Copy link
Member

curquiza commented Nov 4, 2021

Why is there also change about integration tests name in this PR? is this expected?
You can put it in the same, but want to be sure this is expected.

EDIT: I confused, I thought I was asking as reviewer here, but you probably have not finished, sorry!

@bidoubiwa
Copy link
Contributor Author

Why is there also change about integration tests name in this PR? is this expected?
You can put it in the same, but want to be sure this is expected.

Yes it is expected! Should have been in another Pr but I was a bit lazy hhehe

@bidoubiwa bidoubiwa requested a review from curquiza November 8, 2021 13:59
status = [
'style-check',
'integration-tests (Node.js 12)',
'integration-tests (Node.js 14)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 is missing I think

Copy link
Contributor Author

@bidoubiwa bidoubiwa Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont confirm compatibility with node 16 in this PR. This may require additional testing

@bidoubiwa bidoubiwa requested a review from curquiza November 8, 2021 14:35
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Don't forget to change the tests required by GH in the settings ;)

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Nov 8, 2021
@bidoubiwa
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Nov 8, 2021
589: Update ci versions r=bidoubiwa a=bidoubiwa

- [ ] Changes in CI naming should be reflected in `settings/branches/main/`  

Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 8, 2021

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Required status check \"integration-tests\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@curquiza
Copy link
Member

curquiza commented Nov 8, 2021

Don't forget to change the tests required by GH in the settings ;)

You should do it before merging your PR

@bidoubiwa
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 8, 2021
@bors
Copy link
Contributor

bors bot commented Nov 8, 2021

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 8, 2021

@bors bors bot merged commit 5161f2c into main Nov 8, 2021
@bors bors bot deleted the update_ci branch November 8, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants