Skip to content

Conversation

@bidoubiwa
Copy link
Contributor

No description provided.

@bidoubiwa bidoubiwa force-pushed the add_pre_release_tests branch from 43924f3 to 9bfad98 Compare January 6, 2022 15:55
@bidoubiwa bidoubiwa requested a review from curquiza January 6, 2022 15:59
curquiza
curquiza previously approved these changes Jan 6, 2022
@bidoubiwa bidoubiwa changed the base branch from bump-meilisearch-v0.25.0 to main January 6, 2022 16:06
@bidoubiwa bidoubiwa dismissed curquiza’s stale review January 6, 2022 16:06

The base branch was changed.

@bidoubiwa bidoubiwa force-pushed the add_pre_release_tests branch from ca8d3c5 to 34156e1 Compare January 6, 2022 16:08
curquiza
curquiza previously approved these changes Jan 6, 2022
@bidoubiwa bidoubiwa force-pushed the add_pre_release_tests branch from 43603c8 to 507e91e Compare January 6, 2022 16:12
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curquiza
Copy link
Member

curquiza commented Jan 6, 2022

Oops, the types-check are not working, I approved before seeing this

@curquiza
Copy link
Member

curquiza commented Jan 6, 2022

checked with @bidoubiwa we merge this PR despite the type-check failing since it does not impact

@bidoubiwa bidoubiwa merged commit 6ae16d7 into main Jan 6, 2022
@bidoubiwa bidoubiwa deleted the add_pre_release_tests branch January 6, 2022 16:17
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants