-
Notifications
You must be signed in to change notification settings - Fork 66
Add pre release process #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change index creation and wait method in tests * Add types tests * Update meilisearch js
…t-meilisearch into add_pre_release_tests
43924f3 to
9bfad98
Compare
bidoubiwa
commented
Jan 6, 2022
curquiza
previously approved these changes
Jan 6, 2022
ca8d3c5 to
34156e1
Compare
curquiza
previously approved these changes
Jan 6, 2022
43603c8 to
507e91e
Compare
curquiza
approved these changes
Jan 6, 2022
Member
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Member
|
Oops, the types-check are not working, I approved before seeing this |
Member
|
checked with @bidoubiwa we merge this PR despite the type-check failing since it does not impact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.