Skip to content

Conversation

@bidoubiwa
Copy link
Contributor

Per @gmourier tests, these widgets are compatible provided that you meet the requirements.
For example the document structure and the settings.

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Mar 2, 2022
@bidoubiwa bidoubiwa requested a review from brunoocasali March 2, 2022 15:17
@bidoubiwa bidoubiwa force-pushed the add_hierarchicalmenu_breadcrumb_compatibility branch from b0ba0c7 to 8280f0b Compare March 2, 2022 15:18
@bidoubiwa bidoubiwa changed the title Add compatibility with hierarchicalMenu and breadcrumb in readme Add compatibility with hierarchicalMenu/breadcrumb/RatingsMenu in readme Mar 2, 2022
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typos regarding the English (grammarly did, actually 😝)

bidoubiwa and others added 2 commits March 2, 2022 21:39
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@bidoubiwa bidoubiwa requested a review from brunoocasali March 2, 2022 20:39
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

@bidoubiwa
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Mar 3, 2022
682: Add compatibility with hierarchicalMenu/breadcrumb/RatingsMenu in readme r=bidoubiwa a=bidoubiwa

Per `@gmourier` tests, these widgets are compatible provided that you meet the requirements. 
For example the document structure and the settings.

Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 3, 2022

Build failed:

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 3, 2022

@bors bors bot merged commit 12cb544 into main Mar 3, 2022
@bors bors bot deleted the add_hierarchicalmenu_breadcrumb_compatibility branch March 3, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants