Skip to content

Fix naming and beta CI #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2022
Merged

Fix naming and beta CI #813

merged 3 commits into from
Jul 27, 2022

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jul 27, 2022 •
edited
Loading

  • Adds consistency in tests naming accross repo's
  • Adds context / needs and services to access Meilisearch instance

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Jul 27, 2022

bors try

meili-bors bot added a commit that referenced this pull request Jul 27, 2022
@meili-bors
Try #813:
1696f46
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 27, 2022

try

Build succeeded:

@bidoubiwa bidoubiwa marked this pull request as ready for review July 27, 2022 15:01
@bidoubiwa bidoubiwa requested a review from alallema July 27, 2022 15:02
alallema
alallema approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Jul 27, 2022

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 27, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit 3f9ccc6 into main Jul 27, 2022
@meili-bors meili-bors bot deleted the fix_ci_errors branch July 27, 2022 15:14
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bidoubiwa @alallema