Skip to content

Conversation

@curquiza
Copy link
Member

Fixes #915

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jan 16, 2024
@curquiza curquiza requested a review from sanders41 January 16, 2024 17:19
@sanders41
Copy link
Collaborator

Sorry, I don't think I was clear on this. Since this project uses pipenv instead of poetry we won't be able to use poetry for the publish. pipenv doesn't have the ability to publish like poetry does so we will still need to use twine, but we need to pass it the token instead of a user name/password like I did in my poetry example. Now that you have the token created I think, but I'm not sure, that you can do this with twine by changing

        env:
          TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
          TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}

to

        env:
          TWINE_USERNAME:  __token__
          TWINE_PASSWORD: "pypi-${{ secrets.PYPI_API_TOKEN }}"

@curquiza
Copy link
Member Author

My bad, I'm so bad with Python environment!
sorry for this! Changing

env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
TWINE_USERNAME: __token__
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I replace this by something else? 😅
Sorry for the noobie question

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time I did a publish with twine it was still using user names and passwords so I haven't tried this, but I think __token__ is correct here. From what I can find I think it tells twine that the password will be the token.

@curquiza
Copy link
Member Author

trying to check on-line how to do the change, but I don't find anything so far, so not sure my basic change will work, as you said

Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried a twine publish with a token before so I may be wrong, but I think this will work.

@sanders41
Copy link
Collaborator

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jan 16, 2024

@meili-bors meili-bors bot merged commit d52e2df into main Jan 16, 2024
@meili-bors meili-bors bot deleted the fix-pipy-deployment branch January 16, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to publish to PyPi: v0.29.0 is not published

3 participants