-
Notifications
You must be signed in to change notification settings - Fork 97
Update CI to publish to pypi #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry, I don't think I was clear on this. Since this project uses pipenv instead of poetry we won't be able to use poetry for the publish. pipenv doesn't have the ability to publish like poetry does so we will still need to use twine, but we need to pass it the token instead of a user name/password like I did in my poetry example. Now that you have the token created I think, but I'm not sure, that you can do this with twine by changing env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}to env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: "pypi-${{ secrets.PYPI_API_TOKEN }}" |
|
My bad, I'm so bad with Python environment! |
| env: | ||
| TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} | ||
| TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
| TWINE_USERNAME: __token__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I replace this by something else? 😅
Sorry for the noobie question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last time I did a publish with twine it was still using user names and passwords so I haven't tried this, but I think __token__ is correct here. From what I can find I think it tells twine that the password will be the token.
|
trying to check on-line how to do the change, but I don't find anything so far, so not sure my basic change will work, as you said |
sanders41
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried a twine publish with a token before so I may be wrong, but I think this will work.
|
bors merge |
Fixes #915