Skip to content

Update CI to publish to pypi #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Update CI to publish to pypi #917

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d16e2fd
Update CI to publish to pypi
curquiza Jan 16, 2024
5fa112e
Fix indentation
curquiza Jan 16, 2024
3abccb2
Go back to previous publish
curquiza Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pypi-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
pipenv run pip3 install build setuptools wheel twine
- name: Build and publish
env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
TWINE_USERNAME: __token__
Copy link
Member Author

@curquiza curquiza Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I replace this by something else? 😅
Sorry for the noobie question

Copy link
Collaborator

@sanders41 sanders41 Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time I did a publish with twine it was still using user names and passwords so I haven't tried this, but I think __token__ is correct here. From what I can find I think it tells twine that the password will be the token.

TWINE_PASSWORD: "pypi-${{ secrets.PYPI_API_TOKEN }}"
run: |
pipenv run python3 -m build
pipenv run twine upload dist/*