Changes related to the next MeiliSearch release (v0.21.0) #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bot
added
the
skip-changelog
* Fix test by renaming buildDate into commitDate * Improve tests according to alpha 4
curquiza
removed
the
skip-changelog
curquiza
reviewed
Apr 27, 2021
* Update wait_for_pending_update method * Update .rubocop_todo
* Rename fieldsDistribution * Fix rubocop error * Upadate .rubocop_todo.yml
* Fix update test * Fix settings test * Fix search tests * Fix docs tests * Fix rubocop error
* Add phrase search test * Add settings search * Update rubocop todo
curquiza
added
the
breaking-change
Member
|
bors try |
Contributor
tryBuild succeeded: |
bidoubiwa
previously approved these changes
Aug 24, 2021
| - [How to Contribute](#how-to-contribute) | ||
| - [Development Workflow](#development-workflow) | ||
| - [Git Guidelines](#git-guidelines) | ||
| - [Release Process (for internal team only)](#release-process-for-internal-team-only) |
Contributor
There was a problem hiding this comment.
Is this wanted? Just to be sure. I don't know if it is written somewhere in which case my bad
Contributor
|
Not sure if this test should be updated by removing // q_spec.rb
it 'does a basic search with an empty query and a custom ranking rule' do
response = @index.update_ranking_rules([
'typo',
'words',
'proximity',
'attribute',
'wordsPosition',
'exactness',
'asc(objectId)'
])
@index.wait_for_pending_update(response['updateId'])
response = @index.search('')
expect(response['nbHits']).to eq(@documents.count)
expect(response['hits'].first['objectId']).to eq(1)
end |
curquiza
approved these changes
Aug 24, 2021
Member
curquiza
left a comment
curquiza
left a comment
There was a problem hiding this comment.
I applied your changes, thanks @bidoubiwa!
bors merge
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: meilisearch/integration-guides#117
This PR:
This PR is auto-generated for the pre-release week purpose. Exceptionally for this release, the pre-release time will be more than just one week.
Done:
wait_for_pending_updateUpdate wait_for_pending_update method #191attributes_for_facetingintofilterable_attributesRename attributes_for_faceting into filterable_attributes #192 -> BREAKING