-
Notifications
You must be signed in to change notification settings - Fork 48
Added methods add_documents_in_batches, update_documents_in_batches and their tests
#224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for running integration tests, I'm looking through them now ^ |
|
It appears that when I ran the linter originally, I mistakenly removed the "return" statements, which is why the test failed. Sorry about that! |
|
Hello @FlamesRunner, thanks for your PR, I will review it as soon as possible. It's not a small one so I need time to read it carefully :) |
|
Hi @FlamesRunner! For the linter errors, you can run |
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello again @FlamesRunner
The PR seems good to me 🎉
I cannot merge with your linter issue, you can fix with updating the rubocop_todo.yml. See the contributing guidelines for more information: https://github.com/meilisearch/meilisearch-ruby/blob/main/CONTRIBUTING.md#linter-
…ilisearch-ruby into 218-documents-in-batches
|
@curquiza Thanks to CaroFG -- I missed that line entirely! It should be fixed now, let me know if any further changes are needed :) |
|
bors try |
tryBuild succeeded: |
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FlamesRunner
bors merge
If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.
add_documents_in_batches, update_documents_in_batches and their tests
This pull request adds the following methods:
The tests for these methods are:
They are based on their non-batch methods. There are two linter errors:
The linter indicates that there are too many lines for
documents_spec.rb(which I was thinking of correcting by adding a new documents_batch_spec.rb, or the less clean way of changing the linter, etc), and thatindex.rbhas too many lines (this one I am less sure of, as there aren't really any other classes that separate methods and since this is my first PR here, I don't want to introduce anything that might break something). I'm unsure, so I'd like to get some feedback on these.References issue #218.