Skip to content

Update README.md #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 9 commits into from
Oct 12, 2021
Merged

Update README.md #185

bors merged 9 commits into from
Oct 12, 2021

Conversation

@mk1107
Copy link
Contributor

@mk1107 mk1107 commented Oct 7, 2021

Issue #181

I have done changes in readme.md. Please once review it.

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Oct 7, 2021
@curquiza curquiza linked an issue Oct 7, 2021 that may be closed by this pull request
Change books to movies in README.md #181
Closed
3 tasks
curquiza
curquiza requested changes Oct 7, 2021
View reviewed changes
curquiza
curquiza previously approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR

bors merge

If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

bors bot added a commit that referenced this pull request Oct 7, 2021
@bors @mk1107 @curquiza
Merge #185
755373e 
185: Update README.md r=curquiza a=mk1107

Issue #181 

I have done changes in readme.md. Please once review it.

Co-authored-by: mk1107 <kashimohanish@gmail.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Oct 7, 2021

Build failed:

@curquiza
Copy link
Member

curquiza commented Oct 7, 2021

Oh yes, I forgot the README of this repo is specific.
Could you also update the README.tpl?
Check out this section that explains how to update the README: https://github.com/meilisearch/meilisearch-rust/blob/main/CONTRIBUTING.md#update-the-readme-

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 7, 2021

Oh yes, I forgot the README of this repo is specific. Could you also update the README.tpl? Check out this section that explains how to update the README: https://github.com/meilisearch/meilisearch-rust/blob/main/CONTRIBUTING.md#update-the-readme-

For this I am unable to understand what to do
like do i need to revert all changes then run update-readme.sh after that do changes in readme then run check-readme.sh ????

@curquiza
Copy link
Member

curquiza commented Oct 7, 2021

Not revert, you can copy/paste. We just need both files to be modified:

  • README.md
  • and README.tpl

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 7, 2021 •
edited
Loading

So then changing src/lib.rs then running all the given commands will do the work??
As I am unable to get where to do changes in readme.tpl file

@curquiza
Copy link
Member

curquiza commented Oct 7, 2021

Just follow the steps in the CONTRIBUTING.md: https://github.com/meilisearch/meilisearch-rust/blob/main/CONTRIBUTING.md#update-the-readme-
You always need to read the CONTRIBUTING.md file when starting an opensource PR in a repository.

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 7, 2021

Just follow the steps in the CONTRIBUTING.md: https://github.com/meilisearch/meilisearch-rust/blob/main/CONTRIBUTING.md#update-the-readme- You always need to read the CONTRIBUTING.md file when starting an opensource PR in a repository.

I read that there It is saying update src/lib.rs or README.tpl but in README.tpl I am unable to get where to do changes so I did changes in src/lib.rs then run the commands as given but nothing happend

@curquiza
Copy link
Member

curquiza commented Oct 7, 2021

Push the changes you did in README.tpl and src/lib.rs then!

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 7, 2021

Push the changes you did in README.tpl and src/lib.rs then!

Done please once check

Mubelotix
Mubelotix previously approved these changes Oct 8, 2021
View reviewed changes
@mk1107
Copy link
Contributor Author

mk1107 commented Oct 9, 2021

Can you please add hacktoberfest accepted

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 11, 2021

please once check the changes

@curquiza
Copy link
Member

curquiza commented Oct 12, 2021

bors try

bors bot added a commit that referenced this pull request Oct 12, 2021
@bors
Try #185:
e73ee56
@bors
Copy link
Contributor

bors bot commented Oct 12, 2021

try

Build failed:

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 12, 2021 •
edited
Loading

image
I have done as told in the instructions, this is an image of work.
I don't know why there is an error.
Please merge it.

@mk1107 mk1107 requested review from Mubelotix and curquiza October 12, 2021 09:43
@mk1107
Copy link
Contributor Author

mk1107 commented Oct 12, 2021

can you once again add hacktober fest accepted?

@curquiza
Copy link
Member

curquiza commented Oct 12, 2021 •
edited
Loading

Could you please be nicer? One of the hacktoberfest rule is to be respectful. Be more patient please
I'm trying to find out what is happening

@curquiza
Copy link
Member

curquiza commented Oct 12, 2021

bors try

bors bot added a commit that referenced this pull request Oct 12, 2021
@bors
Try #185:
4f270f9
@mk1107
Copy link
Contributor Author

mk1107 commented Oct 12, 2021

Could you please be nicer? One of the hacktoberfest rule is to be respectful. Be more patient please I'm trying to find out what is happening

okay okay sorry for that I was not knowing that, thanks for helping.

@bors
Copy link
Contributor

bors bot commented Oct 12, 2021

try

Build succeeded:

curquiza
curquiza approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 12, 2021

Build succeeded:

@bors bors bot merged commit f740ba0 into meilisearch:main Oct 12, 2021
@brunoocasali brunoocasali mentioned this pull request Mar 21, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

@Mubelotix Mubelotix Awaiting requested review from Mubelotix

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change books to movies in README.md

3 participants

@mk1107 @curquiza @Mubelotix