Skip to content

Conversation

@melihaksoy
Copy link
Owner

@melihaksoy melihaksoy commented Aug 16, 2019

Things that needs implementation:

  • Receiver intent filtering
  • Dependenct module for MainActivity & injection for NavigationReceiver
  • NavigationReceiver intent action checks etc.

Will also work on using custom navArgs and navDirections since now they're created in app module rather then their corresponding module - but this might be another PR.

Current approach should be saved in another branch and kept as an example before this is merged.

This will close #28.

@melihaksoy melihaksoy added the enhancement New feature or request label Aug 16, 2019
@melihaksoy melihaksoy self-assigned this Aug 16, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #30 into master will increase coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   22.09%   22.22%   +0.12%     
==========================================
  Files          53       48       -5     
  Lines         448      414      -34     
  Branches       58       51       -7     
==========================================
- Hits           99       92       -7     
+ Misses        329      303      -26     
+ Partials       20       19       -1
Impacted Files Coverage Δ
.../src/main/kotlin/com/melih/core/actions/Actions.kt 0% <0%> (ø) ⬆️
...tlin/com/melih/core/base/lifecycle/BaseFragment.kt 0% <0%> (ø) ⬆️
.../main/kotlin/com/melih/list/ui/LaunchesFragment.kt 0% <0%> (ø) ⬆️
...om/melih/detail/di/modules/DetailFragmentModule.kt 0% <0%> (ø) ⬆️
...sitory/persistence/converters/BaseListConverter.kt 0% <0%> (-66.67%) ⬇️
...pository/persistence/converters/RocketConverter.kt 0% <0%> (-50%) ⬇️
...ository/persistence/converters/MissionConverter.kt 0% <0%> (-16.67%) ⬇️
.../com/melih/repository/sources/PersistenceSource.kt 15.78% <0%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac588ad...4499755. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #30 into master will increase coverage by 0.61%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   22.09%   22.71%   +0.61%     
==========================================
  Files          53       48       -5     
  Lines         448      405      -43     
  Branches       58       51       -7     
==========================================
- Hits           99       92       -7     
+ Misses        329      294      -35     
+ Partials       20       19       -1
Impacted Files Coverage Δ
.../src/main/kotlin/com/melih/core/actions/Actions.kt 0% <0%> (ø) ⬆️
...tlin/com/melih/core/base/lifecycle/BaseFragment.kt 0% <0%> (ø) ⬆️
.../main/kotlin/com/melih/list/ui/LaunchesFragment.kt 0% <0%> (ø) ⬆️
...om/melih/detail/di/modules/DetailFragmentModule.kt 0% <0%> (ø) ⬆️
...sitory/persistence/converters/BaseListConverter.kt 0% <0%> (-66.67%) ⬇️
...pository/persistence/converters/RocketConverter.kt 0% <0%> (-50%) ⬇️
...ository/persistence/converters/MissionConverter.kt 0% <0%> (-16.67%) ⬇️
.../com/melih/repository/sources/PersistenceSource.kt 15.78% <0%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac588ad...47bebcf. Read the comment docs.

@melihaksoy
Copy link
Owner Author

Changing approach a bit - this will be done via implicit deeplinking in combination with navigation component, no need for broadcasting anymore. Updating issue.

@melihaksoy melihaksoy merged commit 1672199 into master Aug 21, 2019
@melihaksoy melihaksoy deleted the single-activity branch August 21, 2019 15:15
melihaksoy added a commit that referenced this pull request Aug 21, 2019
* CircleCI config fixes

* Implicit deeplinking via navController navigate

* Removed jacoco.exec files. Closes # 32
@melihaksoy melihaksoy changed the title WIP: Single activity approach Single activity approach Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check out other navigation options for single activity pattern

2 participants