-
Notifications
You must be signed in to change notification settings - Fork 36
Single activity approach #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2849633 to
4499755
Compare
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 22.09% 22.22% +0.12%
==========================================
Files 53 48 -5
Lines 448 414 -34
Branches 58 51 -7
==========================================
- Hits 99 92 -7
+ Misses 329 303 -26
+ Partials 20 19 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 22.09% 22.71% +0.61%
==========================================
Files 53 48 -5
Lines 448 405 -43
Branches 58 51 -7
==========================================
- Hits 99 92 -7
+ Misses 329 294 -35
+ Partials 20 19 -1
Continue to review full report at Codecov.
|
|
Changing approach a bit - this will be done via implicit deeplinking in combination with navigation component, no need for broadcasting anymore. Updating issue. |
* CircleCI config fixes * Implicit deeplinking via navController navigate * Removed jacoco.exec files. Closes # 32
Things that needs implementation:
MainActivity& injection forNavigationReceiverNavigationReceiverintent action checks etc.Will also work on using custom
navArgsandnavDirectionssince now they're created inappmodule rather then their corresponding module - but this might be another PR.Current approach should be saved in another branch and kept as an example before this is merged.
This will close #28.