🎨 Palette: Fix invisible loading spinner on white buttons#14
🎨 Palette: Fix invisible loading spinner on white buttons#14google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Added dynamic spinner color mapping (`SPINNER_COLORS`) to `Button.jsx`. - Spinner now defaults to dark blue for `whiteBlue` and black for `white` button variants. - Ensures loading state is visible on all button colors. This resolves a UX issue where the white spinner was invisible on white buttons.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
💡 What: Added dynamic coloring to the loading spinner in the
Buttoncomponent.🎯 Why: The previous spinner was hardcoded to white (
border-white), making it invisible on buttons with white backgrounds (e.g.,whiteandwhiteBluevariants).📸 Before/After:
♿ Accessibility: Users now receive clear visual feedback when an action is processing, regardless of the button style.
PR created automatically by Jules for task 4948715199192834021 started by @arashae