Skip to content

Comments

feat: added deepseek-r1 to embedchain configs#2197

Closed
Riddhimaan-Senapati wants to merge 1 commit intomem0ai:mainfrom
Riddhimaan-Senapati:add_deepseek_to_configs
Closed

feat: added deepseek-r1 to embedchain configs#2197
Riddhimaan-Senapati wants to merge 1 commit intomem0ai:mainfrom
Riddhimaan-Senapati:add_deepseek_to_configs

Conversation

@Riddhimaan-Senapati
Copy link

@Riddhimaan-Senapati Riddhimaan-Senapati commented Feb 7, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I have added DeepSeek (specifically DeepSeek-r1 to embedchains configs let me know if you want another DeepSeek model instead)

Fixes #2183

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I am not sure how to test it, but I used other .yaml files in the configs for inspiration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2025

CLA assistant check
All committers have signed the CLA.

@Riddhimaan-Senapati
Copy link
Author

@femto @mark-watson @xyb Can anyone of you review my PR? Excited to begin contributing to this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add deepseek.yaml

2 participants