Update Readme#7
Merged
Merged
Conversation
icarlosmendez
pushed a commit
to icarlosmendez/mem0
that referenced
this pull request
Jun 7, 2025
Update Readme
11 tasks
whysosaket
added a commit
to whysosaket/mem0
that referenced
this pull request
Apr 24, 2026
…ists Two PR-review follow-ups: 1. Lazy client construction (mem0-integrate + mem0-test-integration). MemoryClient() validates the API key in __init__ via a network call, and OSS Memory() can eagerly initialize embedding/LLM providers. Module-level instantiation breaks the pre-existing test suite at collection time when MEM0_API_KEY is unset, which is a non-invasiveness violation. Addressed in two places: - mem0-integrate step 8: new constraint mem0ai#7 in the subagent system prompt requiring lazy construction (function-local singleton or DI scope; never a top-level global). - mem0-integrate step 7: tests must be importable with the API key unset — the design pressure that forces step 8 to construct lazily. - mem0-test-integration step 3: new static check that greps the write_site / read_site files for module-scope MemoryClient( / Memory( and fails with file:line. Converts the prompted constraint into an enforced gate. 2. Codex in assistant lists. Customer-support agents have been telling Codex users that Mem0 doesn't support Codex because the assistant enumerations omitted it. Added "Codex" right after "Claude Code" in: - README.md (Agent Skills paragraph) - docs/vibecoding.mdx (Agent Skills intro) - skills/README.md (intro) - skills/mem0-integrate/README.md (CLI install heading) - skills/mem0-test-integration/README.md (CLI install heading) Existing skills' READMEs (mem0/, mem0-cli/, mem0-vercel-ai-sdk/) and the Vibecoding Universal Starter Prompt have the same drift; they're out of scope for this PR and will be addressed separately.
8 tasks
kartik-mem0
added a commit
that referenced
this pull request
Jun 5, 2026
- require_admin: handle ADMIN_API_KEY and AUTH_DISABLED on fresh empty DB by falling through to allow bootstrap when no users exist yet, instead of raising 401 (Finding #1) - docker-compose healthcheck: use ${POSTGRES_USER:-postgres} instead of hardcoded -U postgres so custom POSTGRES_USER values work (Finding #2) - require_admin: restore request: Request param (needed for auth_type check) but now used in function body (Finding #7 resolved) - docs: sync migration guide password placeholder with README (Finding #9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.