Skip to content

[codex] 修复 PR preflight warning 与测试覆盖#121

Merged
utopiafar merged 1 commit into
memex-lab:mainfrom
utopiafar:codex/preflight-quality-cleanup
May 17, 2026
Merged

[codex] 修复 PR preflight warning 与测试覆盖#121
utopiafar merged 1 commit into
memex-lab:mainfrom
utopiafar:codex/preflight-quality-cleanup

Conversation

@utopiafar
Copy link
Copy Markdown
Collaborator

Summary

  • 修复 PR preflight analyzer 对比脚本,兼容 flutter analyze stdout 与 --write 产物格式,并把脚本单测接入 workflow
  • 清理当前低成本 analyzer warning/error:移除未使用代码、修正 health strategy 可空赋值、补齐 live tag 声明与 live eval 环境跳过
  • 补充/修正相关链路测试:preflight parser 单测、AgentCacheHelper 单测、agent functional fixture 本地化,压缩 fallback 覆盖保持有效

Tests

  • python3 scripts/compare_flutter_analyze_test.py
  • flutter test --no-pub test/agent/agent_cache_helper_test.dart test/agent_refactor_functional_test.dart test/live_agent_eval_test.dart test/data/services/quick_action_service_test.dart
  • flutter analyze --no-pub --no-fatal-infos --no-fatal-warnings --no-congratulate --write /tmp/memex-analyze-rebased.txt
    • warning/error: 0,剩余为既有 info
  • flutter test --no-pub
    • 278 passed, 2 skipped

Notes

  • 已 rebase 到 upstream/main @ 421c713,rebase 无冲突

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 17, 2026

PR Preflight Summary / PR 预检汇总

中文

  • 统一结论:低风险:两个预检均已完成,质量预检通过,可走普通手动合并流程。
  • Policy preflight:低风险
  • Flutter quality:通过
  • PR head:ada2692217e8c09d30719e84a34485a3aa894e67
  • Policy run:25997183927
  • Flutter run:25997183934

English

  • Combined result: Low risk: both preflights completed and quality passed; use the normal manual merge flow.
  • Policy preflight: LOW RISK
  • Flutter quality: PASS
  • PR head: ada2692217e8c09d30719e84a34485a3aa894e67
  • Policy run: 25997183927
  • Flutter run: 25997183934
PR Policy Preflight / PR 规则预检

PR Policy Preflight / PR 规则预检

中文

  • 判定:低风险
  • 变更文件数:0
  • 变更行数:0
  • Diff 是否截断:false

未发现确定性规则问题。

English

  • Decision: LOW RISK
  • Changed files: 0
  • Changed lines: 0
  • Diff truncated: false

No deterministic policy findings.

PR Flutter Quality / Flutter 质量预检

PR Flutter Quality / Flutter 质量预检

中文

  • 总体:通过
  • Analyzer baseline:通过
  • Test baseline:通过

English

  • Overall: PASS
  • Analyzer baseline: PASS
  • Test baseline: PASS

Flutter Analyzer Baseline

  • Base issues: 356
  • PR issues: 332
  • New issues: 0

No new analyzer issues introduced by this PR.

Flutter Test Baseline

  • Base failures: 3
  • PR failures: 0
  • New failures: 0

No new Flutter test failures introduced by this PR.

@utopiafar utopiafar marked this pull request as ready for review May 17, 2026 17:03
@utopiafar utopiafar merged commit 8b84033 into memex-lab:main May 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant