Skip to content

feat: streamline server health checks during session initialization #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savourylie merged 1 commit into from
Sep 29, 2025
Merged

feat: streamline server health checks during session initialization #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions src/memfuse/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,18 +122,8 @@ async def _request(
if extra_headers:
logger.debug(f"[MEMFUSE API] Extra headers: {extra_headers}")

# Check if the server is running
# Perform the request (health check is handled during init)
try:
if not await self._check_server_health():
# Instead of raising a plain ConnectionError, we raise a custom exception
# with a helpful error message that includes instructions on how to start the server
raise ConnectionError(
f"Cannot connect to MemFuse server at {self.base_url}. "
"Please make sure the server is running.\n\n"
"You can start the server with:\n"
" poetry run memfuse-core"
)

url = f"{self.base_url}{endpoint}"

async with getattr(self.session, method.lower())(
Expand Down Expand Up @@ -218,6 +208,16 @@ async def init(
Returns:
ClientMemory: A client memory instance for the specified user, agent, and session
"""
# Ensure session and validate server health once up front
await self._ensure_session()
if not await self._check_server_health():
raise ConnectionError(
f"Cannot connect to MemFuse server at {self.base_url}. "
"Please make sure the server is running.\n\n"
"You can start the server with:\n"
" poetry run memfuse-core"
)

# Check version compatibility
await self._check_version_compatibility()

Expand Down Expand Up @@ -534,16 +534,8 @@ def _request_sync(
if extra_headers:
logger.debug(f"[MEMFUSE API] Extra headers: {extra_headers}")

# Check if the server is running
# Perform the request (health check is handled during init)
try:
if not self._check_server_health_sync():
raise ConnectionError(
f"Cannot connect to MemFuse server at {self.base_url}. "
"Please make sure the server is running.\n\n"
"You can start the server with:\n"
" poetry run memfuse-core"
)

url = f"{self.base_url}{endpoint}"

response = getattr(self.sync_session, method.lower())(
Expand Down Expand Up @@ -626,6 +618,16 @@ def init(
Returns:
Memory: A synchronous memory instance.
"""
# Ensure session and validate server health once up front
self._ensure_sync_session()
if not self._check_server_health_sync():
raise ConnectionError(
f"Cannot connect to MemFuse server at {self.base_url}. "
"Please make sure the server is running.\n\n"
"You can start the server with:\n"
" poetry run memfuse-core"
)

# Check version compatibility
self._check_version_compatibility_sync()

Expand Down