Skip to content

Conversation

@andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented Aug 12, 2024

Description

Added a callout to top of TTL page warning the user that TTL label and ttl property are reserved for the TimeToLive feature.

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page
  • New documentation page, release related

Related PRs and issues

PR this doc page is related to:
(especially necessary if the PR is related to a release)

Closes:
(paste the link to the issue it closes)

Checklist:

  • Check all content with Grammarly
  • Perform a self-review of my code
  • Make corresponding changes to the rest of the documentation (consult with the DX team)
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

kgolubic and others added 8 commits July 4, 2024 11:01
#873)

* Docs improvements (#799)

* Add NuRaft log file flag (#816)

* Add health checks docs (#833)

* Update HA examples

* Add NuRaft log file env (#848)

* Add leader/follower role (#857)

Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>

* Add coordinator hostname HA configuration option (#860)

* First leader

* Update pages/clustering/high-availability.mdx

Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com>

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>
Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com>

* Add monitoring at runtime docs (#806)

* Added description for hiding sensitive information under database-managment/logs

* database-less connections update (#853)

* Update HA docs

* Added link to correct chapter

* Fixed issues pointed out in pr

* Add comments to PR review

---------

Co-authored-by: Andi <andi8647@gmail.com>
Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>
Co-authored-by: kgolubic <kgolubic@gmail.com>
Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>
Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com>
Co-authored-by: Josipmrden <josip.mrden@memgraph.io>
Co-authored-by: andrejtonev <29177572+andrejtonev@users.noreply.github.com>
Co-authored-by: hal-eisen-MG <145572763+hal-eisen-MG@users.noreply.github.com>
* TTL page

* Update pages/querying/time-to-live.mdx

* Update time-to-live.mdx

* Update menu

* Enterprise tag and timezone callout

* PR comments

---------

Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com>
Co-authored-by: kgolubic <kgolubic@gmail.com>
@vercel
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 2:44pm

@andrejtonev andrejtonev changed the base branch from main to memgraph-2-19 August 12, 2024 14:08
kgolubic
kgolubic previously approved these changes Aug 12, 2024
Copy link
Contributor

@kgolubic kgolubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok to me.

@hal-eisen-MG
Copy link
Contributor

Not seeing any labels yet...

@andrejtonev andrejtonev added status: ready PR is ready for review memgraph-2-19 labels Aug 12, 2024
@kgolubic kgolubic changed the base branch from memgraph-2-19 to main August 14, 2024 14:36
@kgolubic kgolubic dismissed their stale review August 14, 2024 14:36

The base branch was changed.

Copy link
Contributor

@hal-eisen-MG hal-eisen-MG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgolubic kgolubic merged commit c72110a into main Aug 14, 2024
@kgolubic kgolubic deleted the ttl-warning branch August 14, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

memgraph-2-19 status: ready PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants