-
Notifications
You must be signed in to change notification settings - Fork 13
Adds warning regarding the use of TTL label and ttl property #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#873) * Docs improvements (#799) * Add NuRaft log file flag (#816) * Add health checks docs (#833) * Update HA examples * Add NuRaft log file env (#848) * Add leader/follower role (#857) Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com> * Add coordinator hostname HA configuration option (#860) * First leader * Update pages/clustering/high-availability.mdx Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com> --------- Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com> Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com> * Add monitoring at runtime docs (#806) * Added description for hiding sensitive information under database-managment/logs * database-less connections update (#853) * Update HA docs * Added link to correct chapter * Fixed issues pointed out in pr * Add comments to PR review --------- Co-authored-by: Andi <andi8647@gmail.com> Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com> Co-authored-by: kgolubic <kgolubic@gmail.com> Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com> Co-authored-by: Katarina Supe <61758502+katarinasupe@users.noreply.github.com> Co-authored-by: Josipmrden <josip.mrden@memgraph.io> Co-authored-by: andrejtonev <29177572+andrejtonev@users.noreply.github.com> Co-authored-by: hal-eisen-MG <145572763+hal-eisen-MG@users.noreply.github.com>
* TTL page * Update pages/querying/time-to-live.mdx * Update time-to-live.mdx * Update menu * Enterprise tag and timezone callout * PR comments --------- Co-authored-by: Kruno Golubic <46486712+kgolubic@users.noreply.github.com> Co-authored-by: kgolubic <kgolubic@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kgolubic
previously approved these changes
Aug 12, 2024
Contributor
kgolubic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks ok to me.
Contributor
|
Not seeing any labels yet... |
hal-eisen-MG
approved these changes
Aug 14, 2024
Contributor
hal-eisen-MG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a callout to top of TTL page warning the user that
TTLlabel andttlproperty are reserved for the TimeToLive feature.Pull request type
Please check what kind of PR this is:
Related PRs and issues
PR this doc page is related to:
(especially necessary if the PR is related to a release)
Closes:
(paste the link to the issue it closes)
Checklist: