fix: add fallback volume when PVC creation is disabled#226
Merged
as51340 merged 1 commit intomemgraph:mainfrom Apr 20, 2026
Merged
fix: add fallback volume when PVC creation is disabled#226as51340 merged 1 commit intomemgraph:mainfrom
as51340 merged 1 commit intomemgraph:mainfrom
Conversation
When persistentVolumeClaim.createStorageClaim is false, the lib-storage volumeMount was rendered without a corresponding volume definition, causing Kubernetes to reject the pod. Now falls back to the existingClaim PVC if set, or emptyDir otherwise. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
persistentVolumeClaim.createStorageClaimisfalse, thelib-storagevolumeMount was rendered without a corresponding volume definition, causing Kubernetes to reject the pod.Fix: adds a volume entry in the
volumes:section whencreateStorageClaim=false:existingClaimPVC if setemptyDirotherwiseFrom what I understand it could have been introduced by : https://github.com/memgraph/helm-charts/pull/12/changes
There's a couple of way to fix the issue, including adding a condition to the volume mount.
This pr needs a bit more review than my previous PR's I believe.