Skip to content

Allow --storage-access-timeout-sec runtime updates#3882

Merged
andrejtonev merged 3 commits intomasterfrom
runtime_storage_timeout
Mar 11, 2026
Merged

Allow --storage-access-timeout-sec runtime updates#3882
andrejtonev merged 3 commits intomasterfrom
runtime_storage_timeout

Conversation

@andrejtonev
Copy link
Copy Markdown
Contributor

Linked --storage-access-timeout-sec to storage.access_timeout_sec database setting.

@andrejtonev andrejtonev added this to the mg-v3.9.0 milestone Mar 10, 2026
@andrejtonev andrejtonev self-assigned this Mar 10, 2026
@andrejtonev andrejtonev added feature feature Docs needed Docs needed CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=coverage -test=clang_tidy labels Mar 10, 2026
@andrejtonev
Copy link
Copy Markdown
Contributor Author

andrejtonev commented Mar 10, 2026

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Runtime updates allowed for --storaga-access-timeout-sec via database setting "storage.access_timeout_sec". Users can not modify the timeout at runtime and thus avoid a restart. Once storage timeout exception has been seen, the user can increase the timeout as a quick fix. #3882
  • Update storage access timeout flag info (now a run-time flag) documentation#1554
    • Is back linked to this development PR

Copy link
Copy Markdown
Contributor

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also extend the error message with the new following information:

  • the current storage timeout can be checked with SHOW CONFIG;
  • the storage timeout can be increased with SET DATABASE SETTING...

@andrejtonev andrejtonev force-pushed the runtime_storage_timeout branch from 441b8c0 to 8b50d5b Compare March 10, 2026 13:51
@andrejtonev andrejtonev added this pull request to the merge queue Mar 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
@andrejtonev andrejtonev added this pull request to the merge queue Mar 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
@andrejtonev andrejtonev added CI -build=release -test=e2e Run release build and e2e tests on push CI -build=mage -test=amd and removed CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=coverage -test=clang_tidy labels Mar 11, 2026
@andrejtonev andrejtonev force-pushed the runtime_storage_timeout branch from 8b50d5b to e79d784 Compare March 11, 2026 06:33
@sonarqubecloud
Copy link
Copy Markdown

@andrejtonev andrejtonev added this pull request to the merge queue Mar 11, 2026
Merged via the queue into master with commit 859bab2 Mar 11, 2026
42 checks passed
@andrejtonev andrejtonev deleted the runtime_storage_timeout branch March 11, 2026 08:26
@gitbuda gitbuda mentioned this pull request Mar 11, 2026
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI -build=mage -test=amd CI -build=release -test=e2e Run release build and e2e tests on push Docs needed Docs needed feature feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants