struct Pal: Add inner mutability to pal buffer
#950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomPoison
reviewed
Apr 2, 2024
rinon
force-pushed
the
sjc/rav1dframecontext/framedata_mutability
branch
from
63db3b0 to
b4144f9
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
3 times, most recently
from
c3f8db0 to
ef78bbc
Compare
randomPoison
approved these changes
Apr 4, 2024
kkysen
requested changes
Apr 5, 2024
rinon
force-pushed
the
sjc/rav1dframecontext/framedata_mutability
branch
from
b4144f9 to
2cfe342
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
from
ef78bbc to
e7a2e46
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/framedata_mutability
branch
from
2cfe342 to
e603367
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
from
e7a2e46 to
63e9914
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/framedata_mutability
branch
2 times, most recently
from
b6ff24c to
2105c1b
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
2 times, most recently
from
6400056 to
815bb20
Compare
Base automatically changed from
sjc/rav1dframecontext/framedata_mutability
to
main
April 16, 2024 07:49
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
from
815bb20 to
22c7422
Compare
rinon
changed the base branch from
main
to
kkysen/struct-Bounds-simplify-DisjointMut
Collaborator
Author
|
I fixed this up so that we don't allow direct access to the guard cast and instead require users to index using the desired output type. Please take another look. |
kkysen
force-pushed
the
kkysen/struct-Bounds-simplify-DisjointMut
branch
from
e3b8f4f to
3a8ab96
Compare
Base automatically changed from
kkysen/struct-Bounds-simplify-DisjointMut
to
main
April 16, 2024 16:25
kkysen
requested changes
Apr 16, 2024
Collaborator
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
The implementation LGTM, I just had a question about the naming, and also if we can impl Mul<usize> for Bounds.
| bounds: Bounds, | ||
| } | ||
|
|
||
| impl<'a, T: AsMutPtr> DisjointImmutGuard<'a, T, [u8]> { |
Collaborator
There was a problem hiding this comment.
It's fine for now, but as a future potential optimization, we should see if we can add alignment info to the [u8] here, as without it, fn cast has to do an alignment check, even though the buffer we're indexing into is usually already aligned enough.
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
from
22c7422 to
4a716c2
Compare
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
from
4a716c2 to
0d3ac6c
Compare
kkysen
approved these changes
Apr 18, 2024
The pal buffer is a type erased Pixel buffer that needs to be accessed concurrently. This change adds support for casting DisjointMut guards from [u8] buffers to appropriate bitdepth-dependent types that implement FromBytes.
rinon
force-pushed
the
sjc/rav1dframecontext/bitdepth_dependent_disjointmut
branch
from
0d3ac6c to
c9c537b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
palbuffer is a type-erasedPixelbuffer that needs to be accessed concurrently. This change adds support for castingDisjointMutguards from[u8]buffers to appropriate bitdepth-dependent types that implementFromBytes.