Migrate from CircleCI to Github Actions#12
Merged
okramarenko merged 24 commits intomasterfrom Jul 11, 2025
Merged
Conversation
Collaborator
okramarenko
commented
Jul 10, 2025
okramarenko
commented
- updated test expectations and fixtures to match SingleStore 9.0 behavior
- commented out duration checks in some tests due to timing flakiness (execution speed varies by system/load)
Comment on lines
+19
to
+23
| - singlestore/cluster-in-a-box:alma-8.7.12-483e5f8acb-4.1.0-1.17.15 | ||
| - singlestore/cluster-in-a-box:alma-8.5.22-fe61f40cd1-4.1.0-1.17.11 | ||
| - singlestore/cluster-in-a-box:alma-8.1.32-e3d3cde6da-4.0.16-1.17.6 | ||
| - singlestore/cluster-in-a-box:alma-8.0.19-f48780d261-4.0.11-1.16.0 | ||
| - singlestore/cluster-in-a-box:alma-7.8.9-e94a66258d-4.0.7-1.13.9 |
Collaborator
There was a problem hiding this comment.
remove versions that are EOL. Using singlestore-labs/singlestore-supported-versions would be even better, but this would come with migration to the dev image I guess
Comment on lines
+8
to
+9
| SQL_USER_PASSWORD = os.getenv("SQL_USER_PASSWORD") # project UI env-var reference | ||
| S2MS_API_KEY = os.getenv("S2MS_API_KEY") # project UI env-var reference |
Collaborator
There was a problem hiding this comment.
now these are defined in secrets and then in the workflow file, so the comments can be removed
pmishchenko-ua
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.