Correctly set the field and inputName attributes when creating DC#220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute
inputNameis actually wrong, as it is only a getter and not a setter inDataContainer(see https://github.com/contao/core-bundle/blob/master/src/Resources/contao/classes/DataContainer.php#L55). The value of the field can only be set by calling the actual variable name, as the setter allows for that.Secondly, the
inputFieldvariable is intended to define the widget name without affecting the DCA field name. Therefore$dc->fieldshould be set to the actual field, whileinputNameshould be set to the generated name. DC_Table does the same in edit-multiple mode.This also fixes compatibility with the new dcaPicker in Contao 4.4