Skip to content

Run as non root by default #16#17

Merged
mendhak merged 3 commits intomendhak:masterfrom
Sispheor:openshift_support
Dec 15, 2020
Merged

Run as non root by default #16#17
mendhak merged 3 commits intomendhak:masterfrom
Sispheor:openshift_support

Conversation

@Sispheor
Copy link

As a general rule, processes running without root privileges cannot bind to ports below 1024.
This PR bring support for K8S and Openshift deployment.

Very useful tool BTW, thanks.

(Some whitespace has been removed because it's automatic on my IDE (vscode), I recommend you to configure it the same way in your projects)

Support for K8S and Openshift
@mendhak
Copy link
Owner

mendhak commented Dec 15, 2020

Oh I just saw this.

So this is something I had also started doing a while ago as well, but I stopped because I had a concern - if I push this new image, then the original command which people may have as part of automation,

docker run -p 8080:80 -p 8443:443 --rm -t mendhak/http-https-echo

will break right away. That's why I added these instructions in the readme.

What's a good way out of this?

I tried to think of ideas. I could leave the current :latest tag on Docker Hub and stop auto-building it and let it go stale, and only move to versioned tags? So this new PR becomes :15.

Any other ideas?

@Sispheor
Copy link
Author

Sure you can start using versioning. And maintain a changelog to keep people aware of breaking changes.

@mendhak
Copy link
Owner

mendhak commented Dec 15, 2020

Basically I don't want to break stuff for people like me who are already using :latest in scripts/automation etc - only at times like this I realize I should have versioned from the beginning... but I didn't know lots of people would start using it 😅

I will review this PR, going to do some testing etc.

@mendhak mendhak merged commit ec9937f into mendhak:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants