Add env variable to disable express logging#34
Closed
quentinleclerc wants to merge 4 commits intomendhak:masterfrom
Closed
Add env variable to disable express logging#34quentinleclerc wants to merge 4 commits intomendhak:masterfrom
quentinleclerc wants to merge 4 commits intomendhak:masterfrom
Conversation
Owner
|
I've redone the feature with a different environment variable, going in the opposite direction, I didn't want any extra variables required in the Dockerfile. Also I've just removed the dashes completely, I don't think it served a good purpose. I'll close this PR, this is now implemented here: #35 |
Owner
|
OK it's now in tag AAAH I forgot your table! OK I'll add that another time it's a nice useful summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've been needing exactly your software but with a slight change so I figured I might as well upload it, if someone needs it.
I just added an environment variable to disable express logging if not needed. I set it to true in the dockerfile to let the default behaviour unchanged.
Thanks,