Skip to content

replace dockerfile ENTRYPOINT by CMD#9

Merged
mendhak merged 1 commit intomendhak:masterfrom
err0r500:replace_entrypoint_cmd
Oct 9, 2020
Merged

replace dockerfile ENTRYPOINT by CMD#9
mendhak merged 1 commit intomendhak:masterfrom
err0r500:replace_entrypoint_cmd

Conversation

@err0r500
Copy link
Contributor

@err0r500 err0r500 commented Oct 6, 2020

Hello,
This commit just replaces ENTRYPOINT by CMD in the Dockerfile in order to be able to overwrite it if needed.

@mendhak mendhak merged commit 9ca7f2b into mendhak:master Oct 9, 2020
@mendhak
Copy link
Owner

mendhak commented Oct 9, 2020

Thanks for this. I was able to test out overriding the command like so:

docker run --rm -it mendhak/http-https-echo sh
docker run --rm -it mendhak/http-https-echo ash
docker run --rm -it mendhak/http-https-echo node --version

And the normal container running works too. 👍

@mendhak
Copy link
Owner

mendhak commented Oct 9, 2020

Latest version of the image is up on Dockerhub.

@err0r500
Copy link
Contributor Author

err0r500 commented Oct 9, 2020

yes, it's very convenient, especially if you have to wait for another container in a docker-compose (for example)
Thanks for the merge ! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants