Use domConsctruct to place contents in div node #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always create a div node in case there is no starting HTML tag in the content of the widget.
This reverts commit ae164ac.
domConsctruct now always creates a div node and places the contents in that div, causing the appendChild error to no longer occur
JelteMX
added a commit
that referenced
this pull request
Jan 4, 2016
Use domConsctruct to place contents in div node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
domConstruct is used to always create a div node and place the contents in this node. With this the appendChild error will no longer occur.
Fixes #6