Skip to content

Fix-ASC20 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jan 29, 2019
Merged

Fix-ASC20 #9

merged 32 commits into from
Jan 29, 2019

Conversation

@omnajjar
Copy link

@omnajjar omnajjar commented Jan 29, 2019

In this PR the following is done:

  • Updated JQuery to v.3.3.1.
  • Rewrite the widget in JS ES6 Style.
  • Fix sizing issues when dealing with large images.
  • Updated README.md according the changes made.
  • Cropper widget depends on webpack as builder & taskrunner.
  • Some other small improvements & clean-ups.

Osama Najjar added 30 commits January 28, 2019 13:29
init widget with depencies & widget modeler conf
7ed0603
enable having local conf
0f40f0d
cleanup boilerplate code
bc63995
set widget name
fb0ade3
added imports-loader to handle jQuery plugins
e99d8d1
imported jquery plugins
a6f3d5d
refactored update life cycle method & adding subscription
94ae73d
cleanup
2c1f506
lower case widget id, to follow app store widget id
c2d2ff2
fix typoe USe => use
1d5b411
added isMxImage helper
05b7cb6
refactoring is in progress...
b6764c6
deleted old widget, and restructured
55406ca
added test project
9011992
set path to test project
cc6f4a3
ignore some autogenerated test projetc files
a48109c
cleanup unused imports
9cba585
added test cases - different sizes
3ae45bb
added dist version to test
b0c9e67
next readme
0eedad1
next readme
6d792f7
next readme
5c39154
next read me
edc92ab
next readme|
15167fc
added the fixed version of the widget to the module
ff0eb1b
added widget props description
be4f5e7
clean-up & correct typos
0b7972f
clean-up & correct typos
b789192
added repo issue ref
03a5320
bump version --> 1.3.0
8d748b9
@omnajjar omnajjar merged commit 98122fa into master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@melvingrootenboers melvingrootenboers

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omnajjar @melvingrootenboers