Re: DEP-601 Add a heartbeat to the logs#197
Merged
joshp123 merged 4 commits intobuildpack-2.2from Sep 25, 2018
Merged
Conversation
hansthen
force-pushed
the
DEP-601
branch
3 times, most recently
from
84fb7bc to
be9b0e7
Compare
Contributor
|
This PR seems to contain lots of extraneous commits. Is the target branch a long way behind the source branch? |
joshp123
suggested changes
Sep 21, 2018
Contributor
|
Also if you format the code with black, then Travis CI will be happy! 😄 |
So we can also use it to check for missing log lines
added 2 commits
September 25, 2018 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures no empty log files will exist for a day