DEP-562: enable extra java locale providers for java8 or later#201
Merged
joshp123 merged 1 commit intobuildpack-2.2from Sep 26, 2018
Merged
DEP-562: enable extra java locale providers for java8 or later#201joshp123 merged 1 commit intobuildpack-2.2from
joshp123 merged 1 commit intobuildpack-2.2from
Conversation
joshp123
reviewed
Sep 26, 2018
| javaopts = m2ee_section["javaopts"] | ||
|
|
||
| # enable locale for java8 or later | ||
| if not java_version.startswith("7"): |
Contributor
There was a problem hiding this comment.
The comment says "enable locale for java8 or later", but the code says "enable locale for java versions that are not 7".
Are we sure that the only Java versions are 7 and 8+?
Contributor
Author
There was a problem hiding this comment.
yep, we do not support java older than 7 in buildpack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Jira issue for details