Skip to content

COA2-865: remove unused ca#674

Merged
Yornik merged 4 commits into
developfrom
COA2-865_remove_unused_ca
Sep 13, 2023
Merged

COA2-865: remove unused ca#674
Yornik merged 4 commits into
developfrom
COA2-865_remove_unused_ca

Conversation

@Yornik
Copy link
Copy Markdown
Member

@Yornik Yornik commented Sep 12, 2023

svanderburg and others added 4 commits September 6, 2023 16:28
@Yornik Yornik changed the base branch from master to develop September 12, 2023 13:07
@djvdorp djvdorp changed the title Coa2 865 remove unused ca COA2-865: remove unused ca Sep 12, 2023
@djvdorp
Copy link
Copy Markdown
Contributor

djvdorp commented Sep 12, 2023

I can confirm that this change is the minimum required change to add the me-central-1 region which means literally include the content from the following file: https://truststore.pki.rds.amazonaws.com/me-central-1/me-central-1-bundle.pem

This can be confirmed by hand, but since we have had a point in time where there were many (most likely all available ones) were added and then subsequently removed, the diff is hard to read, so I decided to compare this PR against the state before the former PR instead (#668) to have the smallest diff possible. That would be be revision 183f4e5af7f47f47367fcc45a3cc8746aa69137f which is the last change on file etc/amazon-rds-ca.pem before 35e30369c59c13a2f888d716709bee0f21bf80c9 (which is in #668).

The diff matches the content of the AWS-supplied file exactly, so that is confirmed watertight, and can be verified via:

$ git diff 183f4e5af7f47f47367fcc45a3cc8746aa69137f..7395996bc5c9da79b94756a3b97b27fc6777ae4e etc/amazon-rds-ca.pem

@Yornik Yornik merged commit 9edc288 into develop Sep 13, 2023
@jeohist jeohist deleted the COA2-865_remove_unused_ca branch April 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants