Skip to content

Fix for #4 java.security.AccessControlException #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2017
Merged

Fix for #4 java.security.AccessControlException #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d04aba
Fix for #4 java.security.AccessControlException
acdickinson Nov 15, 2016
c8a80a3
Update JdbcConnectionManager.java
acdickinson Nov 15, 2016
baa84c6
Added name for connection pool
arjenw Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions javasource/databaseconnector/impl/JdbcConnectionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public Connection getConnection(final String jdbcUrl, final String userName, fin
final Integer connPoolKey = toConnPoolKey(jdbcUrl, userName);
final HikariDataSource dataSource = connectionPool.computeIfAbsent(connPoolKey, k -> {
logNode.trace(String.format("Creating data source in connection pool for [url=%s, user=%s]", jdbcUrl, userName));
return createHikariDataSource(jdbcUrl, userName, password);
return createHikariDataSource(jdbcUrl, userName, password, connPoolKey);
});
logNode.trace(String.format("Getting connection from data source in connection pool for [url=%s, user=%s]", jdbcUrl, userName));
return dataSource.getConnection();
Expand All @@ -70,9 +70,9 @@ private Integer toConnPoolKey(final String jdbcUrl, final String userName) {
return (jdbcUrl + userName).hashCode();
}

private HikariDataSource createHikariDataSource(final String jdbcUrl, final String userName, final String password) {
private HikariDataSource createHikariDataSource(final String jdbcUrl, final String userName, final String password, Integer connPoolKey) {
final HikariDataSource dataSource = new HikariDataSource();

dataSource.setPoolName(String.format("MxDbConnector-HikaryCP-%d", connPoolKey));
dataSource.setJdbcUrl(jdbcUrl);
dataSource.setUsername(userName);
dataSource.setPassword(password);
Expand Down