Added migration instructions for the customized index.html #9042
Conversation
|
Hi @wrdsnd , are these changes tied to a release or can they be merged after review? |
|
Hi @quinntracy! There is no hurry, this is not tied to a release. |
|
@wrdsnd Great, I'll take a look and merge after review |
|
@Robinfr can you please also take a look? |
|
|
||
| 1. Delete the custom `index.html`, or rename it temporarily. | ||
| 2. Run the local deployment and copy the app/deployment/web/index-example.html to your app/theme/web/index.html. That will be your new `index.html`. | ||
| 3. Apply any changes you want. |
There was a problem hiding this comment.
Apply customization where required.
| 2. Run the local deployment and copy the app/deployment/web/index-example.html to your app/theme/web/index.html. That will be your new `index.html`. | ||
| 3. Apply any changes you want. | ||
|
|
||
| It is also possible to keep custom `index.html` files for both clients. To do this, name the React client index file *index-react.html*. This file will take precedence when the React client is enabled, while the `index.html` will be used for Dojo client deployments. |
There was a problem hiding this comment.
Same here, let's also use code blocks for index-react.html.
There was a problem hiding this comment.
Our style guide uses italics to clarify the name of something, which is why index-react.html is italicized rather than in code formatting. I will change the other places noted above to be in code formatting, though.
| 2. Run the local deployment and copy the app/deployment/web/index-example.html to your app/theme/web/index.html. That will be your new `index.html`. | ||
| 3. Apply any changes you want. | ||
|
|
||
| It is also possible to keep custom `index.html` files for both clients. To do this, name the React client index file *index-react.html*. This file will take precedence when the React client is enabled, while the `index.html` will be used for Dojo client deployments. |
There was a problem hiding this comment.
Can you add why customers might want to do this, e.g. while they are migrating their app?
|
I opened a new PR to add @Robinfr 's feedback to this (also so @ConnorLand can take a look next week and make adjustments, where necessary). |
5 participants
No description provided.