[WC-2752]: fix DG2 refresh in client issue #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelreichert
force-pushed
the
fix/WC-2752-dg2-refresh-in-client
branch
from
2ca693b to
f3a9ccf
Compare
iobuhov
reviewed
Dec 9, 2024
Collaborator
iobuhov
left a comment
iobuhov
left a comment
There was a problem hiding this comment.
LGTM, but need linter fix
iobuhov
previously approved these changes
Dec 9, 2024
leonardomendix
previously approved these changes
Dec 10, 2024
Collaborator
|
bump patch version and add changelog. release directly |
samuelreichert
dismissed stale reviews from leonardomendix and iobuhov
via
55d40a6
leonardomendix
previously approved these changes
Dec 10, 2024
iobuhov
previously approved these changes
Dec 11, 2024
samuelreichert
dismissed stale reviews from iobuhov and leonardomendix
via
5cb5a2c
samuelreichert
force-pushed
the
fix/WC-2752-dg2-refresh-in-client
branch
from
55d40a6 to
5cb5a2c
Compare
samuelreichert
force-pushed
the
fix/WC-2752-dg2-refresh-in-client
branch
from
5cb5a2c to
29b6c1b
Compare
iobuhov
approved these changes
Dec 11, 2024
leonardomendix
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
The issue some customers are facing is when using refresh in client on a microflow in a page with the last version of Datagrid 2 (v2.28). The issue is that when using this microflow on a datagrid to update the data regularly, the loading indicators keep showing up, on every update, and the user simply don't want that. They want the datagrid loading indicator to only show up when doing datasource changes, adding items, or when navigating between pages (paginating).