fix: update column selector to use floating ui #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
force-pushed
the
wc-2824-column-selector
branch
from
3c595ce to
e032b5d
Compare
gjulivan
force-pushed
the
wc-2824-column-selector
branch
from
bd05982 to
00f85b6
Compare
iobuhov
reviewed
Mar 12, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Mar 12, 2025
packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx
Show resolved
Hide resolved
gjulivan
force-pushed
the
wc-2824-column-selector
branch
7 times, most recently
from
189ea6d to
4113b6e
Compare
iobuhov
previously approved these changes
Mar 17, 2025
leonardomendix
previously approved these changes
Mar 20, 2025
gjulivan
force-pushed
the
wc-2824-column-selector
branch
from
4113b6e to
eff2e23
Compare
r0b1n
approved these changes
Mar 20, 2025
leonardomendix
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
column selector overflow detection is not reliable using old method.
this PR is to change it to use floating-ui instead.